added a momentum module to si #115
Conversation
There was a problem hiding this comment.
Few more changes requested. Before merging I'll want all the commits squashed and the commit message changed to be in the imperative: "Add momentum quantity and associated units.
Resolves #114."
dunmatt
force-pushed
the
buildingMomentum
branch
from
adfb405 to
0eb9322
Compare
|
Fixed. And, learning from the experience, I've turned on a ruler (in my editor) at the 100 char mark. Thanks for all the feedback! If you don't mind my asking, what's your background? Are you a senior engineer at CERN or something? |
|
Fixes all look good. Apply the patch below to adjust the where clause formatting and I'll merge! I am a senior software engineer but don't work for anyone as interesting as CERN. Mostly company-internal modeling work. Also lots of reading for this project. diff --git a/src/si/momentum.rs b/src/si/momentum.rs
index 122ab2c..9b19e71 100644
--- a/src/si/momentum.rs
+++ b/src/si/momentum.rs
@@ -193,11 +193,13 @@ mod test {
test::<m::pound, l::foot, t::second, mmm::pound_foot_per_second>();
test::<m::pound, l::inch, t::second, mmm::pound_inch_per_second>();
- fn test<M, L, T, R>() where
+ fn test<M, L, T, R>()
+ where
M: m::Conversion<V>,
L: l::Conversion<V>,
T: t::Conversion<V>,
- R: mmm::Conversion<V> {
+ R: mmm::Conversion<V>
+ {
Test::assert_approx_eq(&Momentum::new::<R>(V::one()),
&(Mass::new::<M>(V::one()) * Length::new::<L>(V::one())
/ Time::new::<T>(V::one()))); |
dunmatt
force-pushed
the
buildingMomentum
branch
from
0eb9322 to
ee3810b
Compare
|
done |
|
Merged! Thanks for putting this together. |
This adds Momentum, per #114 . I'll send another for Torque here in a bit.